Fixed manifest for Firefox, added linting and CI #198
Conversation
|
Not sure while snyk licensing is failing (the only package added was web-ext which has MPL 2.0) - I don't have access to Expensify's Snyk org. |
|
I sent you an invite to Snyk. In the meantime, we can manually mark the check as succsesful in Snyk, which I just did. |
mjasikowski
dismissed stale reviews from dangrous and tgolen
The merge-base changed after approval.
mjasikowski
dismissed
tgolen’s stale review
The merge-base changed after approval.
mjasikowski
dismissed
tgolen’s stale review
The merge-base changed after approval.
|
Still getting auto-rejected :( |
mjasikowski
dismissed
dangrous’s stale review
The merge-base changed after approval.
|
dang, thought i'd be lucky haha |
|
Waiting for GitHub to get back to me on the support ticket |
|
wooo |
|
Yay, that worked. I'm publishing it now and then you can send out an email to everyone announcing the new version once I give you the green light. |
|
OK, green light! I've uploaded it to 1Password.
|
|
Here is an example email I sent out a while ago:
|
|
@tgolen I'll go through the remaining snyk PRs, bump the version number and then deal with the e-mail - at least we'll have a "security updates" changelog entry for that |
Fixed problems with the FF extension by using the
web-extpackage from Mozilla, which helps with linting.Web-ext linting was also added as a step to GitHub actions, so we can be sure it's compatible with Firefox without having to first package and upload to addons.mozilla.org.